Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase envoy route timeout to 5mins #7300

Closed
wants to merge 1 commit into from

Conversation

zduymz
Copy link

@zduymz zduymz commented Feb 14, 2020

default envoy route timeout is 15s. It's not sufficient for request that take long time to process.
An Issue was raised here: #6382
PR add timeout to 5mins

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 14, 2020

CLA assistant check
All committers have signed the CLA.

@jippi
Copy link
Contributor

jippi commented Feb 15, 2020

Isn't this something that can be configured by the end-user in the connect{} stanza? imo it really should - we got many endpoints where an envoy request can take a looooong time (by design), talking +10min easily

@hanshasselberg
Copy link
Member

Thank you for your work @zduymz! Would you want to take a stab at making this configurable? The default is not good for you and I guess someone doesn't like 5minutes either.
Thanks!

@hanshasselberg hanshasselberg self-assigned this Feb 18, 2020
@hanshasselberg hanshasselberg added the waiting-reply Waiting on response from Original Poster or another individual in the thread label Feb 18, 2020
@zduymz
Copy link
Author

zduymz commented Feb 19, 2020

sure @i0rek. What variable name should be? I'm not good at naming concisely.

@ghost ghost removed the waiting-reply Waiting on response from Original Poster or another individual in the thread label Feb 19, 2020
@rboyer
Copy link
Member

rboyer commented Sep 14, 2020

Incidentally, this can already be configured for all clients of a given service by editing that service's service-router config entry and updating the RequestTimeout setting: https://www.consul.io/docs/agent/config-entries/service-router#requesttimeout

Would that work for your use cases, or do you also require this to be configured for individual clients of a service in the upstream configuration itself?

@mikemorris
Copy link
Contributor

mikemorris commented Dec 7, 2020

Closing this as it's been sitting a while with several conflicts now, and I believe the approach we'd want to take would instead be to implement a configurable timeout as described in #6382 if the approach @rboyer suggested isn't sufficient.

@mikemorris mikemorris closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants