ui: Coordinates don't require a nspace, so don't expect one in the repo #7378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
added
type/bug
kaxcode
reviewed
Mar 3, 2020
| service.findAllByDatacenter = function(dc, configuration) { | ||
| assert.equal(arguments.length, 2, 'Expected to be called with the correct number of arguments'); | ||
| assert.equal(dc, datacenter); | ||
| assert.deepEqual(configuration, conf); |
There was a problem hiding this comment.
configuration is not set here so it equals {}. How does it equal cursor: 1?
There was a problem hiding this comment.
Remember we are completely replacing the findAllByDatacenter method here. findByNode calls our fake findAllByDatacenter with the dc and configuration arguments, which it gets from the original call to findAllbyNode('node-name', datacenter, conf), conf being {cursor: 1}, so eventually configuration === {cursor: 1}
Previously we were expecting and passing through an extra nspace argument, which was actually the configuration object, which was the root of the bug.
freddygv
pushed a commit
that referenced
this pull request
Mar 12, 2020
…po (#7378) * ui: Coordinates don't require a nspace, so don't expect one in the repo * Add a test to prove the correct number of arguments are being passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
indexblocking query parameter/cursor is maintained whilst blocking on the coordinates endpoint.