Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error output when agent crashes in an early stage #7411

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Fix error output when agent crashes in an early stage #7411

merged 1 commit into from
Mar 9, 2020

Conversation

johscheuer
Copy link
Contributor

@johscheuer johscheuer commented Mar 8, 2020 •
edited
Loading

Fixes: #7410

With this change the error message are visible to the end user:

$ docker run -ti --read-only consul-dev:latest consul agent  --data-dir='/tmp' --log-level=TRACE
==> Starting Consul agent...
    2020-03-08T19:14:57.212Z [DEBUG] agent: Using random ID as node ID: id=d015aca7-3c10-d715-29dc-a8b799e2cf82
    2020-03-08T19:14:57.212Z [ERROR] agent: Failed to setup node ID: open /tmp/node-id: read-only file system
    2020-03-08T19:14:57.213Z [INFO]  agent: Exit code: code=1

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

hanshasselberg
hanshasselberg approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you for your contribution!

@hanshasselberg hanshasselberg merged commit f8ded99 into hashicorp:master Mar 9, 2020
@johscheuer johscheuer deleted the fix-error-output branch March 9, 2020 16:09
freddygv pushed a commit that referenced this pull request Mar 12, 2020
@johscheuer @freddygv
agent: log error when agent crashes in an early stage (#7411)
35fee6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consul Agent exits silently
3 participants
@johscheuer @hashicorp-cla @hanshasselberg