ci: Use golangci-lint for linting #7440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using golangci-lint has a number of advantages:
adding new linters becomes much easier, its a couple lines of yaml config
instead of more bash scripting
it enables whitelisting of issues using inline comments or regex
when running multiple linters less work is done. The parsed source can be reused
by multiple linters
linters are run in parallel to reduce CI runtime.
This PR also changes the workflow so that more work can be done in parallel. This should reduce the overall workflow runtime by a minute or two.