-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Redesign - Create ConsulExternalSource #7632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaxcode
commented
Apr 10, 2020
•
edited
Loading
edited
- Create ConsulExternalSource with test and styling
- Implement ConsulExternalSource to Service List page
- Update icons for redesign
- Refactor ListCollection and CompositeRow styling
kaxcode
force-pushed
the
ui/feature/external-source-redesign
branch
3 times, most recently
from
April 14, 2020 16:10
56f2520
to
dad6cf0
Compare
kaxcode
force-pushed
the
ui/feature/external-source-redesign
branch
from
April 14, 2020 19:25
dad6cf0
to
592d50a
Compare
kaxcode
changed the title
ui: External source redesign
ui: Redesign - Create ConsulExternalSource
Apr 14, 2020
johncowen
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for giving it another look!
kaxcode
added a commit
that referenced
this pull request
Apr 20, 2020
* Create ConsulExternalSource with test and styling * Implement ConsulExternalSource to Service list page * Update icons for redesign * Refactor ListCollection and CompositeRow styling
johncowen
pushed a commit
that referenced
this pull request
Apr 30, 2020
* Create ConsulExternalSource with test and styling * Implement ConsulExternalSource to Service list page * Update icons for redesign * Refactor ListCollection and CompositeRow styling
kaxcode
added a commit
that referenced
this pull request
May 11, 2020
* Create ConsulExternalSource with test and styling * Implement ConsulExternalSource to Service list page * Update icons for redesign * Refactor ListCollection and CompositeRow styling
johncowen
pushed a commit
that referenced
this pull request
May 12, 2020
* Create ConsulExternalSource with test and styling * Implement ConsulExternalSource to Service list page * Update icons for redesign * Refactor ListCollection and CompositeRow styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.