Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Redesign - Create ConsulExternalSource #7632

Merged
merged 4 commits into from
Apr 14, 2020
Merged

ui: Redesign - Create ConsulExternalSource #7632

merged 4 commits into from
Apr 14, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Apr 10, 2020 •
edited
Loading

  • Create ConsulExternalSource with test and styling
  • Implement ConsulExternalSource to Service List page
  • Update icons for redesign
  • Refactor ListCollection and CompositeRow styling

@kaxcode kaxcode added the theme/ui Anything related to the UI label Apr 10, 2020
@kaxcode kaxcode requested a review from a team April 10, 2020 23:31
@kaxcode kaxcode force-pushed the ui/feature/external-source-redesign branch 3 times, most recently from 56f2520 to dad6cf0 Compare April 14, 2020 16:10
@kaxcode kaxcode force-pushed the ui/feature/external-source-redesign branch from dad6cf0 to 592d50a Compare April 14, 2020 19:25
@kaxcode kaxcode changed the title ui: External source redesign ui: Redesign - Create ConsulExternalSource Apr 14, 2020
johncowen
johncowen approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for giving it another look!

@kaxcode kaxcode merged commit dc667ec into ui-staging Apr 14, 2020
@kaxcode kaxcode deleted the ui/feature/external-source-redesign branch April 14, 2020 20:07
kaxcode added a commit that referenced this pull request Apr 20, 2020
@kaxcode
ui: Redesign - Create ConsulExternalSource (#7632)
1b93c01 
* Create ConsulExternalSource with test and styling

* Implement ConsulExternalSource to Service list page

* Update icons for redesign

* Refactor ListCollection and CompositeRow styling
johncowen pushed a commit that referenced this pull request Apr 30, 2020
@kaxcode
ui: Redesign - Create ConsulExternalSource (#7632)
6dc636a 
* Create ConsulExternalSource with test and styling

* Implement ConsulExternalSource to Service list page

* Update icons for redesign

* Refactor ListCollection and CompositeRow styling
kaxcode added a commit that referenced this pull request May 11, 2020
@kaxcode
ui: Redesign - Create ConsulExternalSource (#7632)
f8b8271 
* Create ConsulExternalSource with test and styling

* Implement ConsulExternalSource to Service list page

* Update icons for redesign

* Refactor ListCollection and CompositeRow styling
johncowen pushed a commit that referenced this pull request May 12, 2020
@kaxcode
ui: Redesign - Create ConsulExternalSource (#7632)
2883164 
* Create ConsulExternalSource with test and styling

* Implement ConsulExternalSource to Service list page

* Update icons for redesign

* Refactor ListCollection and CompositeRow styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaxcode @johncowen