Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Redesign - Instance Detail Proxy Info tab #7745

Merged
merged 4 commits into from
May 7, 2020
Merged

ui: Redesign - Instance Detail Proxy Info tab #7745

merged 4 commits into from
May 7, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Apr 30, 2020 •
edited
Loading

co-authored by: @johncowen

@kaxcode kaxcode added the theme/ui Anything related to the UI label Apr 30, 2020
@kaxcode kaxcode requested review from johncowen and a team April 30, 2020 18:04
@kaxcode kaxcode force-pushed the ui/feature/redesign-instance-detail-proxy-tab branch 3 times, most recently from 4bf79a7 to 3c840ea Compare May 1, 2020 14:50
johncowen
johncowen reviewed May 1, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly all good, typically I had a few comments that are more stylistic things, and there are a couple of things that we'd need to look at (mainly the namespace and prep queries things).

ui-v2/app/components/healthcheck-list/index.hbs Show resolved Hide resolved
ui-v2/app/router.js Outdated Show resolved Hide resolved
ui-v2/app/styles/components/table.scss Show resolved Hide resolved
ui-v2/app/styles/routes/dc/services/index.scss Outdated Show resolved Hide resolved
ui-v2/app/styles/routes/dc/services/index.scss Show resolved Hide resolved
ui-v2/app/templates/dc/services/instance/proxyinfo.hbs Outdated Show resolved Hide resolved
ui-v2/app/templates/dc/services/instance/proxyinfo.hbs Outdated Show resolved Hide resolved
ui-v2/app/routes/dc/services/instance.js Outdated Show resolved Hide resolved
ui-v2/app/styles/components/tabular-details/layout.scss Outdated Show resolved Hide resolved
ui-v2/app/styles/base/components/tabs/layout.scss Outdated Show resolved Hide resolved
@kaxcode kaxcode force-pushed the ui/feature/redesign-instance-detail-proxy-tab branch 2 times, most recently from 6e520c4 to 16e5b43 Compare May 1, 2020 20:05
@preetapan preetapan added this to the 1.8.0 milestone May 4, 2020
@kaxcode kaxcode force-pushed the ui/feature/redesign-instance-detail-proxy-tab branch from 16e5b43 to e6b751f Compare May 6, 2020 20:37
@kaxcode
Copy link
Contributor Author

kaxcode commented May 6, 2020

Screen Shot 2020-05-06 at 4 21 36 PM

@johncowen I've updated Upstreams to include namespace design. Exposed Paths redesign will be in another PR.

@kaxcode kaxcode requested a review from johncowen May 6, 2020 20:40
@kaxcode kaxcode force-pushed the ui/feature/redesign-instance-detail-proxy-tab branch from e6b751f to d8f7c3d Compare May 6, 2020 20:50
johncowen
johncowen reviewed May 7, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all coming together nicely!

I left a few bits and pieces here. It would be good to get this merged though, let's catch up on it later and see if we can finish it off.

ui-v2/app/components/consul-gateway-source/index.js.rej Outdated Show resolved Hide resolved
ui-v2/app/styles/app.scss Show resolved Hide resolved
ui-v2/app/styles/components/composite-row/layout.scss Outdated Show resolved Hide resolved
ui-v2/app/styles/routes/dc/services/index.scss Show resolved Hide resolved
ui-v2/app/routes/dc/services/instance.js Outdated Show resolved Hide resolved
ui-v2/app/templates/dc/services/instance/proxy.hbs Outdated Show resolved Hide resolved
ui-v2/app/templates/dc/services/instance/proxy.hbs Outdated Show resolved Hide resolved
ui-v2/app/templates/dc/services/instance/proxy.hbs Outdated Show resolved Hide resolved
ui-v2/app/templates/dc/services/instance.hbs Show resolved Hide resolved
@kaxcode kaxcode force-pushed the ui/feature/redesign-instance-detail-proxy-tab branch from d8f7c3d to 331fe30 Compare May 7, 2020 13:08
johncowen
johncowen reviewed May 7, 2020
View reviewed changes
ui-v2/app/templates/dc/services/instance/proxy.hbs Outdated
<li class="port">
<CopyButtonFeedback
@copy={{combinedAddress}}
@name="Address to the clipboard"
Copy link
Contributor

@johncowen johncowen May 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I think its just this that needs making into "Address" otherwise the title will say "Copy Address to the clipboard to the clipboard"

// copy-buttonfeed-back.hbs
(concat 'Copy ' name ' to the clipboard')

tbh I'm not even sure if that gets rendered anywhere, but if we did want to add 'to the clipboard' to the feedback tooltip that appears I'd say we should add that into the component itself, personally I wouldn't change that now tho.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. Updating...

johncowen
johncowen approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah cool, I think its just that one more tweak in the CopyButtonFeedback thing, and this is good to go! 👏

kaxcode and others added 3 commits May 7, 2020 09:43
@kaxcode
Create Proxy Info Tab for Instance Detail Page
59aff02
@kaxcode
Create tests for ProxyInfo and update other scenarios with Proxy data
f1ec930
@johncowen @kaxcode
ui: Refactors our app-view/%app-view component (#7752)
8dd005e 
We noticed that it was about time we dug into the app-view component as
the skin of the UI has chnged quite a bit since this component started
and it has now become slightly more consistent. The %app-view CSS has
not changed much and things needed within it have gradually become more
clearer.

Apart from some refactoring of CSS here, the biggest change is the
addition of a `nav` Slot, which gets placed immediately underneath the
title of the page. This contains any main navigation elements for the
page.
@kaxcode kaxcode force-pushed the ui/feature/redesign-instance-detail-proxy-tab branch from 331fe30 to 8dd005e Compare May 7, 2020 13:43
@kaxcode kaxcode merged commit 920f91f into ui-staging May 7, 2020
@kaxcode kaxcode deleted the ui/feature/redesign-instance-detail-proxy-tab branch May 7, 2020 13:57
kaxcode added a commit that referenced this pull request May 11, 2020
@kaxcode @johncowen
ui: Redesign - Instance Detail Proxy Info tab (#7745)
aa045e7 
* Fix clickFirstAnchor bug

* Create Proxy Info Tab for Instance Detail Page

* Create tests for ProxyInfo and update other scenarios with Proxy data

* ui: Refactors our app-view/%app-view component (#7752)

Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
johncowen added a commit that referenced this pull request May 12, 2020
@kaxcode @johncowen
ui: Redesign - Instance Detail Proxy Info tab (#7745)
4b2ff91 
* Fix clickFirstAnchor bug

* Create Proxy Info Tab for Instance Detail Page

* Create tests for ProxyInfo and update other scenarios with Proxy data

* ui: Refactors our app-view/%app-view component (#7752)

Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kaxcode @johncowen @preetapan