Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry picking: Node id conflict backport #7775

Merged
merged 3 commits into from
May 5, 2020

Conversation

hanshasselberg
Copy link
Member

Original PR: #7747.

go.mod Outdated
@@ -76,7 +75,7 @@ require (
golang.org/x/crypto v0.0.0-20191106202628-ed6320f186d4
golang.org/x/net v0.0.0-20190923162816-aa69164e4478
golang.org/x/sync v0.0.0-20190423024810-112230192c58
golang.org/x/sys v0.0.0-20200124204421-9fbb57f87de9
golang.org/x/sys v0.0.0-20200331124033-c3d80250170d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is breaking things

@hanshasselberg
Copy link
Member Author

Down to 1 test failure. 🎉

@mkeeler
Copy link
Member

mkeeler commented May 5, 2020

@i0rek That one can be flaky at times. Nothing with your update.

Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hanshasselberg hanshasselberg merged commit a7dace2 into release/1.7.x May 5, 2020
@hanshasselberg hanshasselberg deleted the node_id_conflict_backport branch May 5, 2020 20:00
alvin-huang pushed a commit to alvin-huang/consul that referenced this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants