Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.7.x] Cherry pick snapshot fixes #7785

Merged
merged 3 commits into from
May 5, 2020
Merged

[1.7.x] Cherry pick snapshot fixes #7785

merged 3 commits into from
May 5, 2020

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented May 5, 2020

Includes #7697 and #7698

@dnephin dnephin requested a review from hanshasselberg May 5, 2020 16:59
@dnephin dnephin force-pushed the cherry-pick-snapshot-fixes branch 2 times, most recently from 10437db to 66e2688 Compare May 5, 2020 17:14
@dnephin dnephin force-pushed the cherry-pick-snapshot-fixes branch from 66e2688 to 3f461f4 Compare May 5, 2020 17:24
hanshasselberg
hanshasselberg approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dnephin dnephin merged commit 46110cd into release/1.7.x May 5, 2020
@dnephin dnephin deleted the cherry-pick-snapshot-fixes branch May 5, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnephin @hanshasselberg @rboyer