Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Improved Login/Logout flow inc SSO support #7790

Merged
merged 19 commits into from
May 11, 2020
Merged

UI: Improved Login/Logout flow inc SSO support #7790

merged 19 commits into from
May 11, 2020

Commits on May 11, 2020

  1. 6 new components for new login/logout flow, plus SSO support 

    UI Components:

1. AuthDialog: Wraps/orchestrates AuthForm and AuthProfile
2. AuthForm: Authorization form shown when logged out.
3. AuthProfile: Simple presentational component to show the users
'Profile'
4. OidcSelect: A 'select' component for selecting an OIDC provider,
dynamically uses either a single select menu or multiple buttons
depending on the amount of providers

Data Components:

1. JwtSource: Given an OIDC provider URL this component will request a
token from the provider and fire an donchange event when it has been
retrieved. Used by TokenSource.
2. TokenSource: Given a oidc provider name or a Consul SecretID,
TokenSource will use whichever method/API requests required to retrieve
Consul ACL Token, which is emitted to the onchange event handler.

Very basic README documentation included here, which is likely to be
refined somewhat.
    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    7d024e3 View commit details
    Browse the repository at this point in the history

  2. CSS required for new auth/SSO UI components

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    795afa9 View commit details
    Browse the repository at this point in the history

  3. Remaining app code required to tie the new auth/SSO work together

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    9be492a View commit details
    Browse the repository at this point in the history

  4. CSS code required to help tie the auth/SSO work together

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    2440da9 View commit details
    Browse the repository at this point in the history

  5. Test code in order to get current tests passing with new auth/SSO flow 

    ..plus extremely basics/skipped rendering tests for the new components
    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    49e56d8 View commit details
    Browse the repository at this point in the history

  6. Treat the secret received from the server as the truth 

    Previously we've always treated what the user typed as the truth, this
breaks down when using SSO as the user doesn't type anything to retrieve
a token. Therefore we change this so that we use the secret in the API
response as the truth.
    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    f4cf5b9 View commit details
    Browse the repository at this point in the history

  7. Tweak some styling and reorg, add a header to the new error page

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    ecee000 View commit details
    Browse the repository at this point in the history

  8. Changes OIDC RedirectURL to /oidc/redirect.html

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    595cb9c View commit details
    Browse the repository at this point in the history

  9. Move OIDC redirect to oidc/callback + dev support due to no cont-type

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    9fe536a View commit details
    Browse the repository at this point in the history

  10. Make the api and contextual components a little more sane 

    Move everything that gets exported to the top level component itself
    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    72a2a76 View commit details
    Browse the repository at this point in the history

  11. Lint

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    1d2b6d7 View commit details
    Browse the repository at this point in the history

  12. Cleanup, a11y improvements, address FIXMEs

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    94abace View commit details
    Browse the repository at this point in the history

  13. Re-remove some CSS following rebase

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    6cf973f View commit details
    Browse the repository at this point in the history

  14. Temporarily fix up some buttons

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    5fea299 View commit details
    Browse the repository at this point in the history

  15. Checking undefined won't work whilst in testing change to a null check

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    cef15e4 View commit details
    Browse the repository at this point in the history

  16. Make sure removing an dom tree from a buffer only removes its own tree

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    f97501e View commit details
    Browse the repository at this point in the history

  17. Stop torii from outputing an unconfigured message

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    896c21c View commit details
    Browse the repository at this point in the history

  18. Add a few more model layer tests and stubs

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    e3fc659 View commit details
    Browse the repository at this point in the history

  19. Fix up rebase

    John Cowen committed May 11, 2020
    Configuration menu
    Copy the full SHA
    df3ed3f View commit details
    Browse the repository at this point in the history