Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add and use ProxyFor to get the connected with proxy boolean #7820

Merged
merged 3 commits into from
May 12, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented May 8, 2020

No description provided.

@kaxcode kaxcode added the theme/ui Anything related to the UI label May 8, 2020
@kaxcode kaxcode requested a review from a team May 8, 2020 18:18
@kaxcode kaxcode force-pushed the ui/feature/use-ProxyFor-for-connected-with-proxy branch from 8f0e32a to 24f41fe Compare May 11, 2020 17:18
@johncowen johncowen added this to the 1.8.0 milestone May 12, 2020
@johncowen johncowen force-pushed the ui/feature/use-ProxyFor-for-connected-with-proxy branch from 24f41fe to cb70928 Compare May 12, 2020 10:37
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we are gonna come back and add some testing on top of in a later PR

@kaxcode kaxcode merged commit f4f60eb into ui-staging May 12, 2020
@kaxcode kaxcode deleted the ui/feature/use-ProxyFor-for-connected-with-proxy branch May 12, 2020 12:06
johncowen pushed a commit that referenced this pull request May 12, 2020
…7820)

* Add and use ProxyFor to get the `connected with proxy` boolean

* Fix up page-navigation test

* Upgrade to @hashicorp/consul-api-double@2.14.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants