ui: Moves/loads policy datacenters info into the policy detail panel #7828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregone
approved these changes
May 11, 2020
kaxcode
pushed a commit
that referenced
this pull request
May 11, 2020
johncowen
added a commit
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7681 we removed the datacenter column from the Role > Policies listing. This was due to the fact that at this point we only know the datacenters of a policy if it had just been saved.
https://github.com/hashicorp/consul/pull/7681/files#diff-d376c2264c9ef1bcb9a5eb4d130ce2f0L59-L61
This re-adds the Datacenter information into the details panel of each Policy instead of into the rows. The contents of this panel are loaded when the panel is opened, which means that when we list the datacenters here they are correct.
Fixes: #7563