Agent connection pool cleanup #7966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanshasselberg
force-pushed
the
pool_improvements
branch
from
f2b8739
to
616819b
Compare
The version field has been used to decide which multiplexing to use. It was introduced in 2457293. But this is 6y ago and there is no need for this differentiation anymore.
hanshasselberg
force-pushed
the
pool_improvements
branch
from
616819b
to
a1e835a
Compare
In the past TLS usage was enforced with these variables, but these days this decision is made by TLSConfigurator and there is no reason to keep using the variables.
Timeout was never used in a meaningful way by callers, which is why it is now entirely internal to the pool.
hanshasselberg
force-pushed
the
pool_improvements
branch
from
a1e835a
to
1fbc1d4
Compare
rboyer
reviewed
Jun 3, 2020
agent/pool/pool.go
Outdated
| var codec rpc.ClientCodec | ||
| conn, _, err := p.DialTimeoutInsecure(dc, nodeName, addr, 1*time.Second, p.TLSConfigurator.OutgoingRPCWrapper()) | ||
| conn, _, err := p.dial(dc, nodeName, addr, 1*time.Second, 0, RPCTLSInsecure) |
There was a problem hiding this comment.
The second to last arg is zero because it doesn't matter what the value is, right? In the prior invocation RPCTLSInsecure was passed for both values (and the second-to-last value was still similarly ignored).
There was a problem hiding this comment.
Yes! dial ignores the second to last value if it is in RPCTLSInsecure mode:
Lines 371 to 376 in 1fbc1d4
hashicorp-ci
pushed a commit
that referenced
this pull request
Jun 5, 2020
Agent connection pool cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some of the cruft from agent connection pool. Best viewed by commit.