CVE-2020-12797: Legacy ACL Token Permission Enforcement #8047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h computed This allows new style token replication to work for legacy tokens as well when they change.
hanshasselberg
added a commit
that referenced
this pull request
Jun 8, 2020
* Fixes #5606: Tokens converted from legacy ACLs get their Hash computed This allows new style token replication to work for legacy tokens as well when they change. * tests: fix timestamp comparison Co-authored-by: Matt Keeler <mjkeeler7@gmail.com>
hanshasselberg
added a commit
that referenced
this pull request
Jun 8, 2020
hanshasselberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consul doesn't enforce changes to legacy ACL tokens rules due to not being propagated to secondary data centers.
Background
When configured to operate in multiple datacenters, Consul will have one of those datacenters act as the primary, while all the rest act as secondary datacenters. All policies, roles, globally scoped tokens and legacy ACLs (pre–1.4.0) can only be created in the primary datacenter, and then replicated to the secondary datacenters.
When using the legacy APIs to create or update legacy ACLs, an internal conversion process does not compute a necessary field. Due to this, when replicating legacy token updates, changes to a legacy ACL tokens rules will not be propagated to a secondary datacenter.
Remediation
Steps to remediate:
Alternatively, potential mitigations include: