decode: do not modify the source data in HookTranslateKeys #8106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
dnephin/hook-translate-keys-make-a-copy
branch
from
3987db0
to
b6fa9b3
Compare
freddygv
reviewed
Jun 15, 2020
This was causing a 'fatal error: concurrent map iteration and map write' with gateways
dnephin
force-pushed
the
dnephin/hook-translate-keys-make-a-copy
branch
from
b6fa9b3
to
d11674d
Compare
freddygv
approved these changes
Jun 15, 2020
hashicorp-ci
pushed a commit
that referenced
this pull request
Jun 15, 2020
…ake-a-copy decode: do not modify the source data in HookTranslateKeys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a 'fatal error: concurrent map iteration and map write' with gateways.
CC @freddygv , @adilyse I believe you two have more context
This was a problem with the old
lib.TranslateKeysas well. I kept the old behaviour in #7963, but this approach (of copying the source before making modifications) seems safer, and is more consistent with mapstructure and other hooks.