decode: do not modify the source data in HookTranslateKeys #8106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a 'fatal error: concurrent map iteration and map write' with gateways.
CC @freddygv , @adilyse I believe you two have more context
This was a problem with the old
lib.TranslateKeys
as well. I kept the old behaviour in #7963, but this approach (of copying the source before making modifications) seems safer, and is more consistent with mapstructure and other hooks.