-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Token listing redesign #8117
Conversation
4f1130e
to
d72382f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📓
content: ', '; | ||
white-space: pre; | ||
content: ','; | ||
margin-right: 0.3em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the tag-listing wasn't wrapping properly when not in listings, this fixes that up.
%definition-table > dl > * { | ||
min-height: 1em; | ||
margin-bottom: 0.4em; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we are using plain dl
s for other things. I moved what was our 'default layout' for dl
s to a 'definition table' component. This means we shouldn't have to keep overwriting dl
margins/padding anymore.
%instances-row > * { | ||
width: calc(100% / 4); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Managed to delete quite a lot of the old table centric CSS for service, instance and token listings.
@@ -1,4 +1,5 @@ | |||
@setupApplicationTest | |||
@ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to ignore this test in the end, not massively happy about that, but ember-tooltips
causes the tests to hang here for a while.
@@ -77,7 +77,7 @@ Feature: dc / acls / tokens / index: ACL Token List | |||
s: Si-Search | |||
--- | |||
And I see 1 token model | |||
And I see 1 token model with the serviceIdentity "Si-Search" | |||
And I see 1 token model with the serviceIdentity "Service Identity: Si-Search" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I'm not massively happy with this change as it depends on the design of the service identity display. I decided to PR this instead of getting deeper into this and adding more and more change here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨 🔥 ♻️ LGTM
64a1a36
to
44ccfb8
Compare
44ccfb8
to
751f99e
Compare
We changed our default definition list layout in #8117. We replaced the default with a definition-table class but missed one place where the old default was previously used. This adds the definition-table class in RTT where it used to use the default.
We changed our default definition list layout in #8117. We replaced the default with a definition-table class but missed one place where the old default was previously used. This adds the definition-table class in RTT where it used to use the default.
We changed our default definition list layout in #8117. We replaced the default with a definition-table class but missed one place where the old default was previously used. This adds the definition-table class in RTT where it used to use the default.
This PR is a redesign of the token listing page.
This necessitated various things, and I'll be adding various self-review comments to try to aid review here:
%composite-list
to add a CSSgrid
layout to allow us to have a right hand grid cell for the actions button.ListComponent
copy-button
component to useStateChart
andTooltip
components. This also meant we could delete theFeedbackDialog
component whose functionality was pretty much a state machine anyway.ListComponent
into higher order components named by their 'consul type' i.e.ConsulSomethingList
and migrate those to use the new block slots.Potential future work/improvements:
%more-popover-menu
to the new CSS files specifically for this component.I've PRed this now as the changeset was growing more than I'd like, but I'll likely to be looking into ^ at some point in the future.