ui: Token listing redesign #8117
Conversation
johncowen
force-pushed
the
ui/feature/token-list-redesign
branch
from
4f1130e
to
d72382f
Compare
| content: ', '; | ||
| white-space: pre; | ||
| content: ','; | ||
| margin-right: 0.3em; |
There was a problem hiding this comment.
I noticed that the tag-listing wasn't wrapping properly when not in listings, this fixes that up.
| %definition-table > dl > * { | ||
| min-height: 1em; | ||
| margin-bottom: 0.4em; | ||
| } |
There was a problem hiding this comment.
Now we are using plain dls for other things. I moved what was our 'default layout' for dls to a 'definition table' component. This means we shouldn't have to keep overwriting dl margins/padding anymore.
| %instances-row > * { | ||
| width: calc(100% / 4); | ||
| } | ||
| } |
There was a problem hiding this comment.
Managed to delete quite a lot of the old table centric CSS for service, instance and token listings.
| @@ -1,4 +1,5 @@ | |||
| @setupApplicationTest | |||
| @ignore | |||
There was a problem hiding this comment.
I had to ignore this test in the end, not massively happy about that, but ember-tooltips causes the tests to hang here for a while.
| @@ -77,7 +77,7 @@ Feature: dc / acls / tokens / index: ACL Token List | |||
| s: Si-Search | |||
| --- | |||
| And I see 1 token model | |||
| And I see 1 token model with the serviceIdentity "Si-Search" | |||
| And I see 1 token model with the serviceIdentity "Service Identity: Si-Search" | |||
There was a problem hiding this comment.
Again, I'm not massively happy with this change as it depends on the design of the service identity display. I decided to PR this instead of getting deeper into this and adding more and more change here.
johncowen
force-pushed
the
ui/feature/token-list-redesign
branch
from
64a1a36
to
44ccfb8
Compare
johncowen
force-pushed
the
ui/feature/token-list-redesign
branch
from
44ccfb8
to
751f99e
Compare
We changed our default definition list layout in #8117. We replaced the default with a definition-table class but missed one place where the old default was previously used. This adds the definition-table class in RTT where it used to use the default.
We changed our default definition list layout in #8117. We replaced the default with a definition-table class but missed one place where the old default was previously used. This adds the definition-table class in RTT where it used to use the default.
We changed our default definition list layout in #8117. We replaced the default with a definition-table class but missed one place where the old default was previously used. This adds the definition-table class in RTT where it used to use the default.
This PR is a redesign of the token listing page.
This necessitated various things, and I'll be adding various self-review comments to try to aid review here:
%composite-listto add a CSSgridlayout to allow us to have a right hand grid cell for the actions button.ListComponentcopy-buttoncomponent to useStateChartandTooltipcomponents. This also meant we could delete theFeedbackDialogcomponent whose functionality was pretty much a state machine anyway.ListComponentinto higher order components named by their 'consul type' i.e.ConsulSomethingListand migrate those to use the new block slots.Potential future work/improvements:
%more-popover-menuto the new CSS files specifically for this component.I've PRed this now as the changeset was growing more than I'd like, but I'll likely to be looking into ^ at some point in the future.