Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Redesigns for the token/policy/roles listings pages #8144

Merged
merged 18 commits into from
Jun 23, 2020

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jun 18, 2020

This PR follows on from #8137.

The new designs for composite-rows that we used for the new token listing page need to be rolled out across all of our listings. A lot of our listings have an 'actions' menu on the right hand side, and in order to add these 'actions' we use several components that work together to make the actions menu plus confirmation etc.

As we reuse various components working together to make this menu, it means it is quite verbose to set up and add to the templates.

Therefore this PR begins by creating a better way to add these menus using a mix of BlockSlots and Contextual components to make the menus less complicated to add.

Menu items and their potential confirmations are now simpler <Action>ActionName</Action> and <Confirmation> Contextual components. All of the wiring together of the various components is now carried out in one place in <ListCollection /> and therefore hidden away from where we need to repeat these menus over and over again.

Admittedly the wiring together of these components index <ListCollection /> is slightly complex due to the contextual components and passing information/actions around. But the thinking is that once all of our listings are using this new approach we can simplify this at a later date.

Secondly this PR then uses these new additions to implement new <ConsulRoleList /> and <ConsulPolicyList /> components.

The pageobjects for the above are also a mixture of various composable component pageobjects, and we stop using our deleteable pageobject helper here in favour of using a pageobject file from the <MorePopoverMenu /> component. Eventually we should be able to phase out these deleteable etc helpers for component pageobjects instead.

Screengrabs:

Screenshot 2020-06-18 at 17 00 04

Screenshot 2020-06-18 at 16 59 55

@johncowen johncowen added the theme/ui Anything related to the UI label Jun 18, 2020
@johncowen johncowen requested a review from kaxcode June 19, 2020 13:07
@johncowen johncowen marked this pull request as ready for review June 19, 2020 13:07
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ 🔥 LGTM

Base automatically changed from ui/feature/node-identities to master June 23, 2020 08:59
@johncowen johncowen added this to the 1.8.x milestone Jun 23, 2020
@johncowen johncowen merged commit 7a8b5e7 into master Jun 23, 2020
@johncowen johncowen deleted the ui/feature/acl-listing-redesign branch June 23, 2020 09:12
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 7a8b5e7 onto release/1.8.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants