-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Redesigns for the token/policy/roles listings pages #8144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxcode
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
♻️ 🔥 LGTM
🍒✅ Cherry pick of commit 7a8b5e7 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on from #8137.
The new designs for composite-rows that we used for the new token listing page need to be rolled out across all of our listings. A lot of our listings have an 'actions' menu on the right hand side, and in order to add these 'actions' we use several components that work together to make the actions menu plus confirmation etc.
As we reuse various components working together to make this menu, it means it is quite verbose to set up and add to the templates.
Therefore this PR begins by creating a better way to add these menus using a mix of BlockSlots and Contextual components to make the menus less complicated to add.
Menu items and their potential confirmations are now simpler
<Action>ActionName</Action>
and<Confirmation>
Contextual components. All of the wiring together of the various components is now carried out in one place in<ListCollection />
and therefore hidden away from where we need to repeat these menus over and over again.Admittedly the wiring together of these components index
<ListCollection />
is slightly complex due to the contextual components and passing information/actions around. But the thinking is that once all of our listings are using this new approach we can simplify this at a later date.Secondly this PR then uses these new additions to implement new
<ConsulRoleList />
and<ConsulPolicyList />
components.The pageobjects for the above are also a mixture of various composable component pageobjects, and we stop using our
deleteable
pageobject helper here in favour of using apageobject
file from the<MorePopoverMenu />
component. Eventually we should be able to phase out thesedeleteable
etc helpers for component pageobjects instead.Screengrabs: