Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent Auto Configuration: Change auto config authorizer to allow for future extension #8148

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Agent Auto Configuration: Change auto config authorizer to allow for future extension #8148

merged 1 commit into from
Jun 18, 2020

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Jun 18, 2020 •
edited
Loading

The configuration now looks like:

auto_config {
   authorization {
      enabled = true
      static {
        // static authorizer settings
      }
   }
}

Where before it looked like:

auto_config {
   authorizer {
      enabled = true
      // static authorizer settings
   }
}

In the future we could add extra settings to enable dynamically defined auth methods to be used instead of or in addition to the statically defined one in the configuration. For now this is just the necessary configuration changes to not box our selves into

@mkeeler mkeeler requested a review from a team June 18, 2020 17:43
@mkeeler mkeeler changed the title Change auto config authorizer to allow for future extension Agent Auto Configuration: Change auto config authorizer to allow for future extension Jun 18, 2020
dnephin
dnephin approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkeeler mkeeler force-pushed the feature/auto-config/static-authz branch from d3e02db to 80118bf Compare June 18, 2020 18:00
@mkeeler
Change auto config authorizer to allow for future extension
389b384 
The envisioned changes would allow extra settings to enable dynamically defined auth methods to be used instead of  or in addition to the statically defined one in the configuration.
@mkeeler mkeeler force-pushed the feature/auto-config/static-authz branch from 80118bf to 389b384 Compare June 18, 2020 18:02
@mkeeler mkeeler merged commit b0fcf86 into master Jun 18, 2020
@mkeeler mkeeler deleted the feature/auto-config/static-authz branch June 18, 2020 19:22
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit b0fcf86 onto release/1.8.x succeeded!

@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkeeler @hashicorp-ci @dnephin