-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge http2 integration test case into grpc case #8164
Conversation
For my own understanding, the "s1 upstream should be able to connect to s2 via grpc" is effectively the replacement for the old "s1 upstream should be able to connect to s2 via http2", is that right? Maybe add a comment above that case to say something about it covers http2 because grpc always uses http2 ? |
@dnephin that's right, I added a comment about that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I missed this earlier. There's a list of test cases now in https://github.com/hashicorp/consul/blob/master/test/integration/connect/envoy/main_test.go#L31 that needs to be updated to remove http2.
otherwise LGTM
🍒✅ Cherry pick of commit cc1407e onto |
http2 is covered by grpc since grpc uses http2
http2 is covered by grpc since grpc uses http2 cherry-pick of #8164 onto origin/release/1.7.x
http2 is covered by grpc since grpc uses http2 cherry-pick of #8164 onto origin/release/1.7.x Co-authored-by: Freddy <freddygv@users.noreply.github.com>
http2 is covered by grpc since grpc uses http2 cherry-pick of #8164 onto origin/release/1.6.x Co-authored-by: Freddy <freddygv@users.noreply.github.com>
http2 is covered by grpc since grpc uses http2 cherry-pick of #8164 onto origin/release/1.6.x Co-authored-by: Freddy <freddygv@users.noreply.github.com> Co-authored-by: Freddy <freddygv@users.noreply.github.com>
Some changes to the fortio image broke the http2 integration test that was previously making a gRPC call using curl.
Since the http2 test case is using gRPC to test http2, this PR adds the additional checks from the http2 case to the gRPC case.
The ping in that test case seems to not be failing because it uses a fortio helper for grpc pings.
Addresses: https://circleci.com/gh/hashicorp/consul/197208