Merge http2 integration test case into grpc case #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For my own understanding, the "s1 upstream should be able to connect to s2 via grpc" is effectively the replacement for the old "s1 upstream should be able to connect to s2 via http2", is that right? Maybe add a comment above that case to say something about it covers http2 because grpc always uses http2 ? |
|
@dnephin that's right, I added a comment about that |
dnephin
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Oh, I missed this earlier. There's a list of test cases now in https://github.com/hashicorp/consul/blob/master/test/integration/connect/envoy/main_test.go#L31 that needs to be updated to remove http2.
otherwise LGTM
|
🍒✅ Cherry pick of commit cc1407e onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jun 22, 2020
http2 is covered by grpc since grpc uses http2
rboyer
pushed a commit
that referenced
this pull request
Jul 7, 2020
http2 is covered by grpc since grpc uses http2 cherry-pick of #8164 onto origin/release/1.7.x
rboyer
added a commit
that referenced
this pull request
Jul 7, 2020
http2 is covered by grpc since grpc uses http2 cherry-pick of #8164 onto origin/release/1.7.x Co-authored-by: Freddy <freddygv@users.noreply.github.com>
rboyer
added a commit
that referenced
this pull request
Jul 21, 2020
http2 is covered by grpc since grpc uses http2 cherry-pick of #8164 onto origin/release/1.6.x Co-authored-by: Freddy <freddygv@users.noreply.github.com>
rboyer
added a commit
that referenced
this pull request
Jul 21, 2020
http2 is covered by grpc since grpc uses http2 cherry-pick of #8164 onto origin/release/1.6.x Co-authored-by: Freddy <freddygv@users.noreply.github.com> Co-authored-by: Freddy <freddygv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to the fortio image broke the http2 integration test that was previously making a gRPC call using curl.
Since the http2 test case is using gRPC to test http2, this PR adds the additional checks from the http2 case to the gRPC case.
The ping in that test case seems to not be failing because it uses a fortio helper for grpc pings.
Addresses: https://circleci.com/gh/hashicorp/consul/197208