Append port number to ingress host domain #8190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crhino
force-pushed
the
ingress/append-port-to-domain
branch
from
014ba40
to
52bc330
Compare
freddygv
reviewed
Jun 26, 2020
A port can be sent in the Host header as defined in the HTTP RFC, so we take any hosts that we want to match traffic to and also add another host with the listener port added. Also fix an issue with envoy integration tests not running the case-ingress-gateway-tls test.
crhino
force-pushed
the
ingress/append-port-to-domain
branch
from
52bc330
to
dca18f7
Compare
|
🍒✅ Cherry pick of commit 735337b onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jul 7, 2020
A port can be sent in the Host header as defined in the HTTP RFC, so we take any hosts that we want to match traffic to and also add another host with the listener port added. Also fix an issue with envoy integration tests not running the case-ingress-gateway-tls test.
blake
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 11, 2021
Update the ingress gateway documentation to remove the note stating that a port must be specified for values in the `hosts` field when the ingress gateway is listening on a non-standard HTTP port. Specifying a port was required in Consul 1.8.0, but that requirement was removed in 1.8.1 with hashicorp/consul#8190 which made Consul include the port number when constructing the Envoy configuration. Related Consul docs PR: hashicorp/consul#10827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A port can be sent in the Host header as defined in the HTTP RFC, so we
take any hosts that we want to match traffic to and also add another
host with the listener port added.
Also fix an issue with envoy integration tests not running the
case-ingress-gateway-tls test.
This fixes issues seen in #8045. Also, see envoy issue envoyproxy/envoy#886 for more context.
This seems like a good improvement/fix to backport to
1.8.1as well, any other thoughts on that welcome.