-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Redesign - Node service instances tab #8204
ui: Redesign - Node service instances tab #8204
Conversation
kaxcode
commented
Jun 29, 2020
- Implemented the ConsulServiceInstancesList component to the Node show page
- Updated the ConsulServiceInstacesList component to work for Nodes and Services
- Created ConsulInstaceChecks component to refactor code and make the template file less busy
- Updates Node test to work with ConsulServiceInstancesList
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far on this! I had a scan of the code and left a couple of comments, nothing major though. I did notice that there is still a bit more to do here also:
and we need to make sure we set up the query parameters in the Controller. Take a look elsewhere on how this is done (or feel free to shout me)
Ping me again when those are done and I can take another look.
I decided to leave the old SearchBar. I need to discuss with designers if the Search/Filter will change again for this page. Will make separate ticket afterwards. |
4eacb4f
to
0b90745
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of tiny things, if you can sort those out and ping me and I can give it a
0b90745
to
0a35316
Compare
0a35316
to
0ec7f4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🍒✅ Cherry pick of commit 7a1284e onto |
* Upgrade consul-api-dobule to version 3.1.3 * Create ConsulInstaceChecks component with test * Redesign: Service Instaces tab in for a Node * Update Node tests to work with the ConsulServiceInstancesList * Style fix to the copy button in the composite-row details * Delete helper and move logic to ConsulInstanceChecks component * Delete unused component consul-node-service-list