ui: Redesign - Node service instances tab #8204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaxcode
commented
Jun 29, 2020
kaxcode
commented
- Implemented the ConsulServiceInstancesList component to the Node show page
- Updated the ConsulServiceInstacesList component to work for Nodes and Services
- Created ConsulInstaceChecks component to refactor code and make the template file less busy
- Updates Node test to work with ConsulServiceInstancesList
johncowen
reviewed
Jun 30, 2020
There was a problem hiding this comment.
Nice work so far on this! I had a scan of the code and left a couple of comments, nothing major though. I did notice that there is still a bit more to do here also:
and we need to make sure we set up the query parameters in the Controller. Take a look elsewhere on how this is done (or feel free to shout me)
Ping me again when those are done and I can take another look.
|
I decided to leave the old SearchBar. I need to discuss with designers if the Search/Filter will change again for this page. Will make separate ticket afterwards. |
kaxcode
force-pushed
the
ui/feature/redesign-node-service-instances-tab
branch
2 times, most recently
from
4eacb4f
to
0b90745
Compare
johncowen
reviewed
Jul 1, 2020
kaxcode
force-pushed
the
ui/feature/redesign-node-service-instances-tab
branch
from
0b90745
to
0a35316
Compare
kaxcode
force-pushed
the
ui/feature/redesign-node-service-instances-tab
branch
from
0a35316
to
0ec7f4e
Compare
|
🍒✅ Cherry pick of commit 7a1284e onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jul 1, 2020
* Upgrade consul-api-dobule to version 3.1.3 * Create ConsulInstaceChecks component with test * Redesign: Service Instaces tab in for a Node * Update Node tests to work with the ConsulServiceInstancesList * Style fix to the copy button in the composite-row details * Delete helper and move logic to ConsulInstanceChecks component * Delete unused component consul-node-service-list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.