Add Revision to version CLI output and add JSON support #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
force-pushed
the
feature/improved-version-output
branch
from
d1fc590
to
f0b4476
Compare
alvin-huang
reviewed
Jul 8, 2020
| @@ -0,0 +1,3 @@ | |||
| Consul 1.99.3-beta1 | |||
| Revision 5e5dbedd47a5f875b60e241c5555a9caab595246 | |||
There was a problem hiding this comment.
I don't know if this is an issue but there may be a tool/check in people's pipelines that parses the protocol from the 2nd line or tail -n 1 or something where this may break. In which case we would suggest them use the json formatter from now on.
There was a problem hiding this comment.
This should probably hold for v1.9 then. So merging to master and not backporting into release/1.8 is the way to go.
There was a problem hiding this comment.
Hmm, thinking about it I am not sure whether we should consider this a breaking change. We provide no guarantees about the output.
Also add JSON format support
mkeeler
force-pushed
the
feature/improved-version-output
branch
from
f0b4476
to
680ac0c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatters style was taken from similar code for the ACL CLI.