Simplify DNS server startup check #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify waiting for the DNS server to start with the newer "NotifyStartedFunc" callback.
By using the startup callbacks, the DNS test entry is not needed to check that the server is alive.
|
This is quite a bit less jank. Thanks! |
armon
added a commit
that referenced
this pull request
Apr 1, 2015
Simplify DNS server startup check
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Force delete pods that are still running after `helm uninstall` so the next installation can begin immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "dns" package added a parameter to pass a callback to be notified when the server has started. Using this simplifies checking that the server is up, and removes the hard-coded timeout, which as the comments note
is jank😉I also removed the code that responds for the special
_test.consul.. This was used by the startup check, but no longer seems necessary.