Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark its own cluster as healthy when rebalancing. #8406

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Mark its own cluster as healthy when rebalancing. #8406

merged 1 commit into from
Aug 6, 2020

Conversation

hanshasselberg
Copy link
Member

@hanshasselberg hanshasselberg commented Jul 30, 2020 •
edited
Loading

This code started as an optimization to avoid doing an RPC Ping to
itself. But in a single server cluster the rebalancing was led to
believe that there were no healthy servers because foundHealthyServer
was not set. Now this is being set properly.

Fixes #8401.

@hanshasselberg
Mark its own cluster as healthy when rebalancing.
4f2337f 
This code started as an optimization to avoid doing an RPC Ping to
itself. But in a single server cluster the rebalancing was led to
believe that there were no healthy servers because foundHealthyServer
was not set. Now this is being set properly.

Fixes #8401 and #8403.
@dnephin dnephin added theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics and removed theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization labels Aug 5, 2020
dnephin
dnephin approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanshasselberg hanshasselberg merged commit 51a8e15 into master Aug 6, 2020
@hanshasselberg hanshasselberg deleted the fix_rebalance branch August 6, 2020 08:42
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 51a8e15 onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Aug 6, 2020
@hanshasselberg @hashicorp-ci
Mark its own cluster as healthy when rebalancing. (#8406)
1a351d5 
This code started as an optimization to avoid doing an RPC Ping to
itself. But in a single server cluster the rebalancing was led to
believe that there were no healthy servers because foundHealthyServer
was not set. Now this is being set properly.

Fixes #8401 and #8403.
@hanshasselberg hanshasselberg mentioned this pull request Aug 10, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single Node / Dev Cluster starts emitting RPC errors after 2 minutes of running
3 participants
@hanshasselberg @hashicorp-ci @dnephin