xds: revert setting set_node_on_first_message_only to true when generating envoy bootstrap config #8440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating envoy bootstrap config When consul is restarted and envoy that had already sent DiscoveryRequests to the previous consul process sends a request to the new process it doesn't respect the setting and never populates DiscoveryRequest.Node for the life of the new consul process due to this bug: envoyproxy/envoy#9682 Fixes #8430
rboyer
added
type/bug
|
🍒✅ Cherry pick of commit 397019d onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Aug 5, 2020
…ating envoy bootstrap config (#8440) When consul is restarted and an envoy that had already sent DiscoveryRequests to the previous consul process sends a request to the new process it doesn't respect the setting and never populates DiscoveryRequest.Node for the life of the new consul process due to this bug: envoyproxy/envoy#9682 Fixes #8430
rboyer
added a commit
that referenced
this pull request
Aug 5, 2020
…o true when generating envoy bootstrap config This is a backport of #8440 to 1.7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consul is restarted and an envoy that had already sent DiscoveryRequests to the previous consul process sends a request to the new process it doesn't respect the
set_node_on_first_message_onlysetting and never populates DiscoveryRequest.Node for the life of the new consul process due to this bug: envoyproxy/envoy#9682Fixes #8430