Notify alias checks when aliased service is [de]registered #8456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
reviewed
Aug 7, 2020
rboyer
reviewed
Aug 7, 2020
| @@ -1912,6 +1912,59 @@ func TestAgent_AliasCheck(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestAgent_AliasCheck_ServiceNotification(t *testing.T) { | |||
There was a problem hiding this comment.
if you comment out the patch, does this test fail?
There was a problem hiding this comment.
Yep this would fail. We only used to notify alias checks if checks were updated. Now we notify about changes to aliased services as well.
|
🍒✅ Cherry pick of commit d72f72d onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when monitoring alias checks locally we have two mechanisms for updating the status of the alias check:
PR #7384 added a check so that alias health checks do not pass if the underlying service doesn't exist. However, we did not notify existing alias checks when services were added/removed. This means we could wait up to a minute to update the check status in these cases (per item 2 above).
This PR triggers an alias check notification when services are added or removed from local state.