Anti-entropy sync services/checks missing entirely from Consul #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| l.serviceStatus[id] = syncStatus{inSync: false} | ||
| } | ||
| } | ||
|
|
||
| if services != nil { |
There was a problem hiding this comment.
It looks like we guard against services result being nil. Can we move that above the new code and just do something like:
if services == nil {
services = make(map...)
}
This way we can avoid the guard logic and nesting. I think the new code here may be susceptible to a nil pointer dereference in those cases. Not that I see how we could get nil back.
|
Minor nitpick, but LGTM! |
ryanuber
added a commit
that referenced
this pull request
Apr 10, 2015
Anti-entropy sync services/checks missing entirely from Consul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #839
/cc @armon