Fix panic when decoding 'Connect: null' #8537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
added
type/bug
hanshasselberg
approved these changes
Aug 19, 2020
Surprisingly the json Unmarshal updates the aux pointer to a nil.
dnephin
force-pushed
the
dnephin/fix-panic-on-connect-nil
branch
from
d058c6f
to
07ad662
Compare
|
🍒✅ Cherry pick of commit 01745fe onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Aug 20, 2020
Fix panic when decoding 'Connect: null'
This was referenced Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8529
Surprisingly the
json.Unmarshalupdates theauxpointer to a nil, even though it was passed in non-nil.Note that while this fixes the panic, that request would still fail with a
400becauseProxyDestinationwas removed in 65be587 and a704ebe made unknown fields fail validation.If we backport this fix to 1.6.x, that request should work.