agent: ensure that we normalize bootstrapped config entries #8547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
commented
Aug 21, 2020
| } | ||
| ] | ||
| } | ||
| }`}, | ||
| hcl: []string{` | ||
| config_entries { | ||
| bootstrap { | ||
| kind = "proxy-defaults" |
There was a problem hiding this comment.
This test had to change because the Normalize method for proxy-defaults always forces the Name field to be global
rboyer
commented
Aug 21, 2020
| @@ -3772,6 +3775,8 @@ func TestBuilder_BuildAndValide_ConfigFlagsAndEdgecases(t *testing.T) { | |||
| } | |||
| }, | |||
| }, | |||
| // TODO(rb): add in missing tests for ingress-gateway (snake + camel) | |||
There was a problem hiding this comment.
I noticed these, but adding them in is outside of the targeted scope of this particular fix.
|
🍒✅ Cherry pick of commit d184345 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all other ways to commit config entries to the state store we
Normalize()before invokingValidate()save for the bootstrap angle which this PR corrects.