ui: [Bugfix] KV creation from within a 'folder' #8613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
force-pushed
the
ui/bugfix/kv-folder-create
branch
from
5b89863 to
def0906
Compare
johncowen
force-pushed
the
ui/bugfix/kv-folder-create
branch
from
def0906 to
9c90108
Compare
johncowen
force-pushed
the
ui/bugfix/kv-folder-create
branch
from
9c90108 to
719b475
Compare
|
🍒✅ Cherry pick of commit 5cc1fef onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Sep 9, 2020
* ui: Prefill an newly created KV for the when we are on a create route * ui: Add some KV creation tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8307 moved the KV area to use KVForm and KVListing components.
This unfortunately broke the creation of KVs when within a folder.
This fixes the bug by prefilling an empty KV for the form if we are on a create page.
We also added some more acceptance tests here.