Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: add support for envoy 1.16.0, drop support for 1.12.x, and bump point releases as well #8944

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Oct 13, 2020

(Backports will be handled separately as each major release runs different supported verisons)

Supported versions will be: "1.16.0", "1.15.2", "1.14.5", "1.13.6"

  • In the correct release branch update the default ENVOY_VERSION value in run-tests.sh. It should contain the new version
  • update the supported version list baked into the agent self endpoint which is shared for the xds golden tests
  • regenerate the golden test outputs and delete any for older versions that have rolled off the list
  • Update the CI jobs in .circleci/config.yml. There are multiple jobs named envoy-integration-test-* where the oldest has a full definition while the others are aliases that just change the version number.
    • Update the version numbers such that they match the new supported list.
    • Update the list of envoy-integration-test-* jobs in the test-integrations workflow to match the new job names changes above.
  • Update the supported versions list in the docs in website/source/connect/proxies/envoy.md
  • Create a PR for consul-k8s to update the default Envoy image to be the latest supported version. Consul will support envoy 1.16.0 with Consul 1.9 consul-k8s#303
  • Create PR for consul-helm to update the default Envoy image. Consul will support envoy 1.16.0 with Consul 1.9 consul-helm#562
  • Create an issue for Nomad to update the default Envoy docker image they use in their integration

@github-actions github-actions bot added theme/cli Flags and documentation for the CLI interface theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified labels Oct 13, 2020
@mikemorris mikemorris added this to the 1.9 milestone Oct 19, 2020
@rboyer rboyer marked this pull request as ready for review October 21, 2020 15:12
@rboyer rboyer requested a review from a team October 21, 2020 15:13
@rboyer rboyer self-assigned this Oct 21, 2020
@rboyer rboyer removed theme/cli Flags and documentation for the CLI interface type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified labels Oct 21, 2020
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rboyer Where does the checklist in the PR comment live? I think the second item should be updated to reflect the new location of EnvoyVersions

rboyer added a commit that referenced this pull request Oct 22, 2020
…1.2, 1.10.0 for 1.7.x (#9000)

Selective backport of #8944 to 1.7.x
rboyer added a commit that referenced this pull request Oct 22, 2020
…2.7, 1.11.2 for 1.8.x (#8999)

Selective backport of #8944 to 1.8.x
@rboyer
Copy link
Member Author

rboyer commented Oct 22, 2020

LGTM

@rboyer Where does the checklist in the PR comment live? I think the second item should be updated to reflect the new location of EnvoyVersions

The checklist is somewhere in google docs and it's already quite out of date. I think @mikemorris was going to move it somewhere to live with the "how to add config" blob, but I don't know the status of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-beta theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants