Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add filtered by in Nspaces, Legacy ACLs, Tokens, Roles and Policies #9531

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jan 8, 2021

This continues on from #9442, #9497 (which is the base branch for this PR), by adding the 'Filtered by' functionality to Nspaces, Legacy ACLs, Tokens, Roles and Policies (the top level, restricted areas).

Additional notes:

  • Moved a few model hooks to async (only was is actually async)

Apart from that its mainly 'copy/pasta, tweak, tweak, tweak' five times.

@johncowen johncowen added the theme/ui Anything related to the UI label Jan 8, 2021
@johncowen johncowen requested a review from kaxcode January 8, 2021 14:29
@johncowen johncowen marked this pull request as ready for review January 8, 2021 14:29
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Base automatically changed from ui/feature/top-level-filter-by to ui/feature/services-filter-by January 19, 2021 15:37
@vercel
Copy link

vercel bot commented Jan 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hashicorp/consul/6g2q1olyn
✅ Preview: Canceled

@johncowen johncowen merged commit 23824d4 into ui/feature/services-filter-by Jan 19, 2021
@johncowen johncowen deleted the ui/feature/restricted-top-level-filter-by branch January 19, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants