Minor documentation fixes #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gmr
commented
Apr 30, 2014
gmr
commented
- Correct spotted typos
- Ran JSON snippets through jsonpp for consistent display of JSON results
- Unfortunately my editor stripped EOL whitespace so there's a bit of whitespace diff
- Fixed the check TTL & interval values, consul raises an exception when passed in as strings
- Correct spotted typos - Ran JSON snippets through jsonpp for consistent display of JSON results - Unfortunately my editor stripped EOL whitespace so there's a bit of whitespace diff
| "Script": "/usr/local/bin/check_mem.py", | ||
| "Interval": "10s", |
There was a problem hiding this comment.
These should be strings. The numeric value 10 actually means 10 nanoseconds in this case.
There was a problem hiding this comment.
Should I open an issue on the string format not working then?
curl --verbose \
> -i \
> -H "Accept: application/json" \
> -X PUT -d '{"ID": "mem", "Name": "Memory utilization", "Notes": "Ensure we dont oversubscribe memory", "Script": "/usr/local/bin/check_mem.py", "Interval": "10s", "TTL": "15s"}' \
> http://localhost:8500/v1/agent/check/register
> PUT /v1/agent/check/register HTTP/1.1
> User-Agent: curl/7.30.0
> Host: localhost:8500
> Accept: application/json
> Content-Length: 165
> Content-Type: application/x-www-form-urlencoded
< HTTP/1.1 400 Bad Request
< Date: Wed, 30 Apr 2014 19:33:44 GMT
< Content-Length: 88
< Content-Type: text/plain; charset=utf-8
Request decode failed: json: cannot unmarshal string into Go value of type time.Durations826
|
If you could review the |
|
@gmr That was also an issue with 0.1. Fix is in master. |
|
LGTM! Thanks! |
armon
added a commit
that referenced
this pull request
Apr 30, 2014
website: Minor documentation fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.