Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add 'filtered by' to Healthchecks and ServiceInstance listings #9622

Merged

Conversation

johncowen
Copy link
Contributor

This continues on from #9442 (which is the base branch for this PR), by adding the 'Filtered by' functionality to Healthchecks, and ServiceInstances (sub Node tabs).

@johncowen johncowen added the theme/ui Anything related to the UI label Jan 22, 2021
@johncowen johncowen requested a review from kaxcode January 22, 2021 17:20
@johncowen johncowen changed the title ui: Add 'filtered by' to Healthchecks and ServiceInstance listsings ui: Add 'filtered by' to Healthchecks and ServiceInstance listings Jan 22, 2021
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@vercel
Copy link

vercel bot commented Jan 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

consul-ui-staging – ./ui

🔍 Inspect: https://vercel.com/hashicorp/consul-ui-staging/2vpi6qyvs
✅ Preview: Failed

@johncowen
Copy link
Contributor Author

I spoke to @jnwright about the capitalization of the check types in the filter menus, and she said she'd prefer them to be lowercased, so I just switched that up in the last commit here before merging.

@johncowen johncowen merged commit 88a8789 into ui/feature/services-filter-by Jan 25, 2021
@johncowen johncowen deleted the ui/feature/sub-service-filter-by branch January 25, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants