Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix copyright text with SPDX tag #39

Open
adam-moss opened this issue Feb 13, 2023 · 2 comments
Open

Prefix copyright text with SPDX tag #39

adam-moss opened this issue Feb 13, 2023 · 2 comments

Comments

@adam-moss
Copy link

Currently the copyright text is provided as a comment.

In the same way the license is prefixed with the SPDX-License-Identifer: tag, should this be prefixed with the SPDX-FileCopyrightText: tag per https://spdx.github.io/spdx-spec/v2.3/file-tags/#h2-file-tags-format ?
adam-moss added a commit to adam-moss/copywrite that referenced this issue Feb 13, 2023
@adam-moss
Add SPDX-Copyright-Text tag
212fd24 
Prefix the copyright text with SPDX-FileCopyrightText to allow for
easier machine parser of SPDX data.

Closes hashicorp#39

Signed-off-by: Adam Moss <2951486+adam-moss@users.noreply.github.com>
@adam-moss
Copy link
Author

@CalebAlbers can I get some thoughts on this please?

@CalebAlbers
Copy link
Member

@adam-moss apologies for the delay. I've transitioned to a different team internally and @dlaguerta has the final say on things now, but I'm happy to provide some thoughts.

Generally speaking, I'm 100% in favor of this. Supporting the SPDX-compliant tag makes sense. I do think we should make it an optional thing, though, as (for better or worse) copywrite is used across a few thousand projects both internal and external to HashiCorp and switching to the SPDX-FileCopyrightText tag would be a breaking change.

Perhaps we can update #40 to use a config/command-line flag for now, and then consider switching the default behavior along with other changes in a v2 release?

adam-moss added a commit to adam-moss/copywrite that referenced this issue Nov 13, 2023
@adam-moss
Add SPDX-Copyright-Text tag
a1a2003 
Prefix the copyright text with SPDX-FileCopyrightText to allow for
easier machine parser of SPDX data.

Closes hashicorp#39

Signed-off-by: Adam Moss <2951486+adam-moss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adam-moss @CalebAlbers