Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
  • Loading branch information
didoo and alex-ju authored May 20, 2022
1 parent 264c497 commit 5829e9b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .changeset/warm-buckets-fold.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
- the button responds to `space` key event
- removed the `@type` argument from the API in favour of the `type` native attribute - 🚨 **Breaking change!**

#Link/LinkTo::CTA
# Link/LinkTo::CTA
- removed the `<Hds::Link/LinkTo::CTA>` component, in favour of `<Hds::Button>` component (see above) - 🚨 **Breaking change!**

# Link::Inline
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<p class="dummy-paragraph">
A
<strong>"Link Inline"</strong>
is a link that's used in within a body of text.
is a link that's used within a body of text.
</p>

<h5 class="dummy-h6">Example of Link (Inline):</h5>
Expand Down Expand Up @@ -156,8 +156,8 @@
<h5 class="dummy-h5">Styling</h5>
<p class="dummy-paragraph"><strong>Important</strong>: the only CSS styling applied to the component is to handle the
two available colors (see below) and their values depending on the interaction states (eg.
<em>hover, focus, active</em>). All the other properties, expecially the font styling, are inherited from the parent
container, mimicking the default behaviour of the
<em>hover, focus, active</em>). All the other properties, especially the font styling, are inherited from the parent
container, mimicking the default behavior of the
<code class="dummy-code">&lt;a&gt;</code>
HTML element.</p>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<h2 class="dummy-h2">Interactive</h2>
<p class="dummy-paragraph">🚧
<em>Notice: this component is intended for internal use for now. It may be that in the future it will exposed as
<em>Notice: this component is intended for internal use for now. It may be that in the future it will be exposed as an
official component of the design system but not for now. Please if you need to use it speak with the HDS team.</em></p>

<section>
Expand Down Expand Up @@ -109,7 +109,7 @@
<p class="dummy-paragraph"><em>We add these attributes by default because this is the most common case (internal links
are generally handled using a
<code class="dummy-code">@route</code>
argument). This behaviour can be overridden (see below).</em>
argument). This behavior can be overridden (see below).</em>
</p>
<p class="dummy-paragraph">If an
<code class="dummy-code">@isHrefExternal</code>
Expand Down

0 comments on commit 5829e9b

Please sign in to comment.