TooltipButton: Converted component to TypeScript
#2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shleewhite
commented
Aug 5, 2024
| offset: this.args.offset, | ||
| showOnCreate: true, | ||
| // takes array of 2 numbers (skidding, distance): array(0, 10) | ||
| offset: this.args.offset ? this.args.offset : [0, 10], |
There was a problem hiding this comment.
Note: turns out the default if offset is not provided is [0,10] not [0,0]
shleewhite
commented
Aug 5, 2024
|
|
||
| export interface HdsTooltipIndexSignature { | ||
| Args: { | ||
| extraTippyOptions: Omit<TippyProps, 'placement' | 'offset'>; |
There was a problem hiding this comment.
Note: since placement and offset will always get overwritten on line 53, I figure we just omit them from the type to avoid confusion.
didoo
approved these changes
Aug 6, 2024
| offset: this.args.offset, | ||
| showOnCreate: true, | ||
| // takes array of 2 numbers (skidding, distance): array(0, 10) | ||
| offset: this.args.offset ? this.args.offset : [0, 10], |
alex-ju
approved these changes
Aug 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Converts TooltipButton to typescript
🔗 External links
Jira ticket: HDS-2718
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.