Convert SuperSelect
components to TypeScript
#2356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Convert
SuperSelect
components to TypeScriptπ οΈ Detailed description
SuperSelect::Single
components to TypeScriptSuperSelect::Multiple
components to TypeScriptNotable changes:
PowerSelectComponent
class to using thepublicAPI
(this is because we now need to extend the glimmerComponent
; it also makes more sense to uncouple the classes and use the API instead)SuperSelect::Single
(changed fromresults
tototal
as per design)π External links
Jira ticket: HDS-2723
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.