Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): add instance-initializers to appReexports #2433

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Sep 19, 2024

πŸ“Œ Summary

We need to add instance-initializers otherwise it will not be registered by consuming app there may be side effects if consumer uses ember-flight-icons still

πŸ› οΈ Detailed description

πŸ“Έ Screenshots

πŸ”— External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

@aklkv aklkv self-assigned this Sep 19, 2024
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Sep 23, 2024 2:10pm
hds-website βœ… Ready (Inspect) Visit Preview Sep 23, 2024 2:10pm

@aklkv aklkv requested a review from a team September 19, 2024 20:22
@aklkv aklkv changed the title fix(components): add instance instance-initializers to appReexports fix(components): add instance-initializers to appReexports Sep 19, 2024
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been running into this issue in #2439 as well – thanks for raising this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants