SuperSelect::Multiple - fix placeholder style and layout
#2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
approved these changes
Oct 2, 2024
|
|
||
| <SF.Item {{style flex="1"}} @label="Selected"> | ||
| </SG.Item> | ||
| <SG.Item @label="With placeholder"> |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
SuperSelect::Singlehas an HDS-level component for the placeholder, managing the mark-up and the style.However, the placeholder for
SuperSelect::Multipleis more complex and doesn't sit at the HDS-level. Hence it requires font style adjustments (only when the search is not enabled) and layout adjustments to fill the parent container (otherwise it will result in trimmed text, as reported by our consumers).📸 Screenshots
🔗 External links
Jira ticket: HDS-3916
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.