[WIP] Add icon support to "Link::Inline" component
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
3 tasks
didoo
force-pushed
the
spike-link-inline
branch
2 times, most recently
from
c4a1e4a to
5035d6a
Compare
didoo
force-pushed
the
spike-add-icon-to-link-inline
branch
from
8e81533 to
f580744
Compare
… fixed issue with leading/trailing icon # Conflicts: # packages/components/addon/components/hds/link/inline.hbs
|
Decided to merge the branch and ask for a single review instead of two, to speed up the process. |
didoo
changed the title
icon support to "Link::Inline" component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is a spike to understand if it's possible to add support for
iconto theLink::Inlinecomponent.Now, while the results show that it's technically possible, I am a bit wary of implementing it, because is likely not used that much (and can be achieved independently, because the content is
yieldedso the consumer can add generic content (icon + textincluded) and organize its layout how the see fit.Another reason for this, is that achieving this in Figma is not possible, because is not a "block" component, so it's more of a style than a component (and you can't apply icons to styles). I can expand on this if it's not obvious what I mean.
Personally I would prefer to document how to do it in the "How to use" section, with a real example, than doing it as done in this PR (likely this will solve only a sub-set of all the possible cases).