-
Notifications
You must be signed in to change notification settings - Fork 50
Form::SuperSelect::Multiple
: Implement updated designs
#2824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a lot better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 This is fantastic!!! Everything fits the exact specifications, really good job 🎊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool improvement on what was existing. Just spotted one small style thing.
packages/components/src/styles/components/form/super-select.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Dylan Hyun <dylan.hyun@hashicorp.com>
a108075
to
727a1cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
📌 Summary
If merged, this PR would update the design of the multiselect super select to improve the experience when many items are selected.
📸 Screenshots
Before

After

🔗 External links
Jira ticket: HDS-4756
Figma file: Final updated designs
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.