Skip to content

Conversation

shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Apr 15, 2025

📌 Summary

If merged, this PR would update the design of the multiselect super select to improve the experience when many items are selected.

📸 Screenshots

Before
Screenshot 2025-04-15 at 4 44 00 PM

After
Screenshot 2025-04-15 at 4 45 01 PM

🔗 External links

Jira ticket: HDS-4756
Figma file: Final updated designs


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Apr 16, 2025 8:20pm
hds-website ✅ Ready (Inspect) Visit Preview Apr 16, 2025 8:20pm

zamoore
zamoore previously approved these changes Apr 15, 2025
Copy link
Contributor

@zamoore zamoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot better

majedelass
majedelass previously approved these changes Apr 16, 2025
Copy link
Contributor

@majedelass majedelass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 This is fantastic!!! Everything fits the exact specifications, really good job 🎊

Copy link
Contributor

@dchyun dchyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool improvement on what was existing. Just spotted one small style thing.

dchyun
dchyun previously approved these changes Apr 16, 2025
Copy link
Contributor

@majedelass majedelass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@shleewhite shleewhite merged commit e4d1335 into main Apr 17, 2025
16 checks passed
@shleewhite shleewhite deleted the hds-4756/super-select-design-update branch April 17, 2025 15:04
@hashibot-hds hashibot-hds mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants