fix: import paths that are missing /index
#2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
reviewed
Apr 22, 2025
Contributor
didoo
left a comment
didoo
left a comment
There was a problem hiding this comment.
A couple of things, before approving:
- can you add a meaningful description to the PR? (for future reference, to give context to the reviewer, etc)
- can you move the code changes to the tests to a different PR? so the two changes are kept separated (I am not sure how this related to this PR; I suspect this should have been done time ago when we postponed the Enterprise Navigation release; which btw is likely coming back soon :) )
Collaborator
Author
|
I will put it on hold, SFC work might supersede this PR |
Contributor
While you work on this, and is not ready for review, can you move it to "draft"? Thanks |
Collaborator
Author
|
I think it's ready now, I have updated description, but let me know if it;s even worth merging this since this issues will keep coming up till we switch over to vite. IMO I think it's worth it, it will make the switch cleaner |
didoo
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
/indexshould always be present. This most likely will come back till we move to vite completely🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.