Modal: replace last instance of this.isOpen with this._isOpen
#2834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shleewhite
changed the title
Modal: replace last instance of this.isOpen with this._isOpenModal: replace last instance of this.isOpen with this._isOpen
dchyun
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would replace the last instance of
this.isOpenwiththis._isOpen. This fixes an issue where clicking anywhere on the page dismisses the inline modals and blocks you from being able to click the demo buttons to open modals.Preview showcase page
Steps to reproduce bug:
🔗 External links
Jira ticket: HDS-4714
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.