Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a11y info to button documentation #315

Merged
merged 1 commit into from
May 25, 2022

Conversation

MelSumner
Copy link
Contributor

📌 Summary

If merged, this PR adds the relevant accessibility information to the Hds::Button component.

👀 How to review

👉 Review by files changed

Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022

⚠️ No Changeset found

Latest commit: eeb4564

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hds-components ✅ Ready (Inspect) Visit Preview May 25, 2022 at 7:20PM (UTC)
hds-flight-website ✅ Ready (Inspect) Visit Preview May 25, 2022 at 7:20PM (UTC)

@MelSumner MelSumner requested review from didoo, alex-ju and Dhaulagiri May 25, 2022 19:19
@vercel vercel bot temporarily deployed to Preview – hds-components May 25, 2022 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 25, 2022 19:20 Inactive
@MelSumner MelSumner merged commit 59b8ac1 into spike-BUTTON-LINK-CTA-main May 25, 2022
@MelSumner MelSumner deleted the melsumner/button-a11y branch May 25, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants