Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock status - Complete migration #321

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

didoo
Copy link
Contributor

@didoo didoo commented May 26, 2022

๐Ÿ“Œ Summary

This is a follow-up of #314, where we updated only some of the dummy documentation pages (and components).

๐Ÿ› ๏ธ Detailed description

In this PR I have:

  • updated remaining pages and components to use the new mock-status approach for mocking visual states

๐Ÿ‘€ How to review

๐Ÿ‘‰ Review by files changed

Reviewer's checklist:

  • +1 Percy if applicable

๐Ÿ’ฌ Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented May 26, 2022

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Updated
hds-components โœ… Ready (Inspect) Visit Preview May 26, 2022 at 7:48PM (UTC)
hds-flight-website โœ… Ready (Inspect) Visit Preview May 26, 2022 at 7:48PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2022

โš ๏ธ No Changeset found

Latest commit: bfbe948

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@didoo didoo marked this pull request as ready for review May 26, 2022 19:48
@vercel vercel bot temporarily deployed to Preview โ€“ hds-flight-website May 26, 2022 19:48 Inactive
@vercel vercel bot temporarily deployed to Preview โ€“ hds-components May 26, 2022 19:48 Inactive
@didoo didoo requested review from MelSumner, alex-ju and Dhaulagiri May 26, 2022 19:48
Copy link
Collaborator

@Dhaulagiri Dhaulagiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work ok in the review app

Non-blocking โ“

I feel like I'm often the changeset ๐Ÿ‘ฎโ€โ™‚๏ธ, but I think you could argue we should include a changeset for these since they do touch public code and could introduce bugs customers might be confused by without a changelog entry ๐Ÿคท. What do you think?

@didoo
Copy link
Contributor Author

didoo commented May 27, 2022

I feel like I'm often the changeset ๐Ÿ‘ฎโ€โ™‚๏ธ, but I think you could argue we should include a changeset for these since they do touch public code and could introduce bugs customers might be confused by without a changelog entry ๐Ÿคท. What do you think?

@Dhaulagiri I swear, this time I thought of it (the changeset) and I concluded that it's not necessary (that's why I intentionally removed it from the "Reviewer's checklist:").

@Dhaulagiri
Copy link
Collaborator

๐Ÿ‘ thanks for letting me work through this out loud

@didoo didoo merged commit b863ae1 into main May 27, 2022
@didoo didoo deleted the mock-status-complete-migration branch May 27, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants