Skip to content

[WIP] [Project Solar / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 42 commits into
base: project-solar/phase-1-main-feature-branch
Choose a base branch
from
Draft

[WIP] [Project Solar / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase #3240

wants to merge 42 commits into from

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Sep 25, 2025

📌 Summary

This is a WIP, which contains the porting of previous showcase theming explorations (squashed).

This is based on top of #3237

🛠️ Detailed description

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel Vercel
Copy link

vercel bot commented Sep 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Error Error Oct 2, 2025 11:45am
hds-website Error Error Oct 2, 2025 11:45am

@didoo didoo mentioned this pull request Sep 25, 2025
Draft
5 tasks
@didoo didoo changed the title [WIP] [Project Solaris / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase [WIP] [Project Solis / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase Sep 25, 2025
@didoo didoo changed the title [WIP] [Project Solis / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase [WIP] [Project Solar/ Phase 1 / Showcase] Add support for theming and theme-switching to the showcase Sep 25, 2025
@didoo didoo changed the title [WIP] [Project Solar/ Phase 1 / Showcase] Add support for theming and theme-switching to the showcase [WIP] [Project Solar / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase Sep 25, 2025
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from b73dbf9 to a4f41dd Compare September 30, 2025 14:11
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from a4f41dd to cc61972 Compare September 30, 2025 14:20
@didoo didoo force-pushed the project-solar/phase-1-main-feature-branch branch from 519a6a6 to 3863dfa Compare September 30, 2025 14:50
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from 92910be to a1ff2f5 Compare September 30, 2025 20:23
didoo and others added 21 commits October 2, 2025 12:37
@didoo
added two new themed tokens generated files, for Scss mixins and for …
9bcc21c 
…combined strategies
@didoo
TEMP - Re-generated tokens
1a855c1
@alex-ju @didoo
Draft a custom plugin to compile the themed SCSS
40e85a2
@didoo
updated SCSS files organization for components (split common part) + …
95f52ff 
…added custom source files for theming + updated rollup config to process different files
@didoo
added support for source maps for generated themed CSS files
3a40e13
@didoo
TEMP - Added generation of “alt” CSS for HDS components to compare wi…
fcbe7c9 
…th output from `rollup-plugin-scss`
@didoo
abstracted logic for custom Rollup plugin to compile multiple Sass fi…
77cf091 
…les to CSS files
@didoo
updated includePaths for design tokens in Showcase and Website `emb…
ccb2660 
…er-cli-build.js`
@didoo
moved compilation of existing Scss files for components and overrides…
2d15ee6 
… to new custom plugin
@didoo
removed rollup-plugin-scss dev dependency (we use our own custom pl…
4d022d0 
…ugin for every Scss compilation)
@didoo
added CSS compilation for combined-strategies tokens
bb949c9
@didoo
added Hds::ThemeSwitcher component
a9880a6
@didoo
added Hds::Theming service
ad4081b
@didoo
added theming to the Showcase itself (and replaced hardcoded values w…
03cc2d0 
…ith `—shw` CSS variables)
@didoo
added Shw::ThemeSwitcher component for showcase
7adcb8b
@didoo
updated Mock::App and added new yielded sub-components
97c5559
@didoo
added Shw:: ThemeSwitcher to the Showcase page header
07095c1
@didoo
added foundations/theming showcase page (and a frameless demo)
0d10871
@didoo
refactored hds-theming service to align with the new themes/modes a…
95608fd 
…nd be open to configurations
@didoo
sq
40581cc
@didoo
WIP
ce65667
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from da7b528 to ce65667 Compare October 2, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/components packages/tokens project solar showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@didoo @hashibot-hds @alex-ju