Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor yield helper component #354

Merged
merged 5 commits into from
Jun 9, 2022
Merged

Refactor yield helper component #354

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00e74ff
refactored `yield` helper component to be a “pure” yield
didoo Jun 9, 2022
983761e
updated integration tests
didoo Jun 9, 2022
9e1f251
updated documentation
didoo Jun 9, 2022
e7997ee
changeset
didoo Jun 9, 2022
8495fed
linting!
didoo Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rotten-sloths-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": patch
---

small update to the `yield` helper component - this is used in `Alert` and `Toast` but the changes should have no impact
5 changes: 2 additions & 3 deletions packages/components/addon/components/hds/yield/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
<div ...attributes>
{{yield}}
</div>
{{!-- template-lint-disable no-yield-only --}}
{{yield}}
5 changes: 1 addition & 4 deletions packages/components/tests/dummy/app/templates/components/alert.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,7 @@
</dd>
<dt>&lt;[A].Generic&gt; <code>yielded component</code></dt>
<dd>
<p>It is a very simple component that yields its content (inside a
<code class="dummy-code">&lt;div&gt;</code>) and accepts
<code class="dummy-code">...attributes</code>
spreading.</p>
<p>It is a very simple component that yields its content.</p>
<p><em>Notice: generic the content will appear at the bottom, after title, description and actions, and the
developer will need to take care of spacing, layout and styling of the custom content in this case.</em></p>
<p>🚨
Expand Down
4 changes: 3 additions & 1 deletion packages/components/tests/integration/components/hds/dropdown/index-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ module('Integration | Component | hds/dropdown/index', function (hooks) {
<Hds::Dropdown id="test-dropdown" as |dd|>
<dd.ToggleButton @text="toggle button" id="test-toggle-button" />
<dd.Description @text="description" id="test-list-item-description" />
<dd.Generic id="test-list-item-generic" />
<dd.Generic>
<div id="test-list-item-generic" />
</dd.Generic>
<dd.Interactive @route="components.dropdown" @text="interactive" id="test-list-item-interactive" />
<dd.Separator id="test-list-item-separator" />
<dd.Title @text="title" id="test-list-item-title" />
Expand Down