Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable programmatic close on dropdown component #399

Merged
merged 5 commits into from
Jun 22, 2022
Merged

Enable programmatic close on dropdown component #399

merged 5 commits into from
Jun 22, 2022

Commits on Jun 21, 2022

  1. Expose close function on disclosure 

    We rename the `deactivate` function to `close` (to ease the adoption and keep it simple) and expose it as part of the disclosure utility component API
    @alex-ju
    alex-ju committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    aa948af View commit details
    Browse the repository at this point in the history

  2. Add close function to dropdown 

    We forward the `close` function from disclosure to dropdown and expose it as part of the dropdown component API
    @alex-ju
    alex-ju committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    22e09f2 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @alex-ju
    alex-ju committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    62e3077 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Use button element to test close function

    @alex-ju
    alex-ju committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2a5eb25 View commit details
    Browse the repository at this point in the history

  2. Use button element to test close function 

    Interactive without @route renders a button
    @alex-ju
    alex-ju committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    899dec3 View commit details
    Browse the repository at this point in the history