Badge component - Add font weight declaration #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ff236b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
alex-ju
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Makes sense! I'm not sure about the value of redefining this property for the required badge in this case.
Yes, we shouldn't in that case. |
heatherlarsen
requested changes
Jul 6, 2022
didoo
force-pushed
the
badge-add-font-weight-declaration
branch
from
68539bb
to
dbe79f7
Compare
didoo
force-pushed
the
badge-add-font-weight-declaration
branch
from
dbe79f7
to
ff236b2
Compare
@heatherlarsen 🤦♂️ I thought it was the same CSS for both. Now it's fixed. |
heatherlarsen
approved these changes
Jul 7, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Following this comment by @heatherlarsen #425 (comment) I've realized we never explicitly set the
font-weightproperty for the text in theBadgecomponent. This has two problems: 1) it inherits from the container, as Heather noticed, and 2) it was using the wrong weight, it should be "medium".🛠️ Detailed description
In this PR I have:
Badgecomponent👀 How to review
👉 Review commit-by-commit or by files changed
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.