Fix whitespace issue in Link::Inline and Interactive utility component
#668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3c3b670 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Dhaulagiri
reviewed
Nov 2, 2022
didoo
approved these changes
Nov 3, 2022
alex-ju
force-pushed
the
fix-white-space-issue-on-interactive-component
branch
from
66de483 to
3c3b670
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Fix whitespace issue in
Link::InlineandInteractiveutility component.🛠️ Detailed description
'Squishies' all the way. To make sure we're not leaving any whitespace behind, I added the designated whitespace control character
~to all conditional statements in theHds::Interactivetemplate, with direct effects on theLink::Inlinecomponent. This would probably become the norm for any inline components in the library.📸 Screenshots
Check visual regression diff in Percy 🦔
Before
After
🔗 External links
Addressing the issue flagged in #231 (comment) and by @efgold via Slack and via GitHub
👀 How to review
👉 Review commit-by-commit
👉 Review by files changed
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.